Bravo List
Register
Go Back   > Bravo List > Source Code > Archived Trackers > Yuna Scatari Edition (YSE) > Mods & Themes
Reply
  #1  
Old 28th March 2021, 19:23
Elena's Avatar
Elena Elena is offline
Senior Member
 
Join Date: Sep 2010
Posts: 71
Thumbs up github new version
https://github.com/lolyworlds/LoLi-v3.0
Reply With Quote
  #2  
Old 29th March 2021, 17:32
rio's Avatar
rio rio is offline
Senior Member
 
Join Date: May 2019
P2P
Posts: 53
Default
You really need to use a code formatting tool just looking at that gave me cancer.
__________________
Live Free... Share Free...

Last edited by rio; 30th March 2021 at 00:28. Reason: typo
Reply With Quote
  #3  
Old 29th March 2021, 19:49
Elena's Avatar
Elena Elena is offline
Senior Member
 
Join Date: Sep 2010
Posts: 71
Default
Quote:
Originally Posted by rio View Post
You really need to use a code formatting tool just looking at the gave me cancer.
Everything is fine there, if you want with a bunch of gaps and emptiness - these are YOUR problems, you can make them for yourself. Everything is fine there - less file weight, faster opening. If there are many spaces, the reading speed slows down. Tests were made and it is not in vain that there are services that compress codes and compact them, removing emptiness and unnecessary garbage.
Reply With Quote
  #4  
Old 29th March 2021, 20:44
rio's Avatar
rio rio is offline
Senior Member
 
Join Date: May 2019
P2P
Posts: 53
Default
Minifying php code has no significant performance improvements it's negligible at best.
https://stackoverflow.com/questions/...ng-php/4079952
__________________
Live Free... Share Free...
Reply With Quote
  #5  
Old 29th March 2021, 22:02
Elena's Avatar
Elena Elena is offline
Senior Member
 
Join Date: Sep 2010
Posts: 71
Default
Quote:
Originally Posted by rio View Post
Minifying php code has no significant performance improvements it's negligible at best.
https://stackoverflow.com/questions/...ng-php/4079952
I repeat once again - these are your problems. You can leave at least 100 points of emptiness. The code is well written and works fast. And you have nothing to do there, you cannot improve, because you do not know the whole picture of the work.
Reply With Quote
  #6  
Old 29th March 2021, 22:36
DND's Avatar
DND DND is offline
VIP
 
Join Date: Dec 2008
Posts: 1,136
Default
your well written and fast code is still using mysql instead of mysqli or pdo .. enough said
but who likes it, likes it and will use it..despite the serious downfall
__________________
Need HELP!? I can install:

  1. Server/VPS (Debian,CentOS,Ubuntu,Fedora, FreeBSD) Optimization and ... + Modules
  2. Webserver Windows/Linux (Apache/Lighttpd/Nginx/Mysql/PhpMyAdmin/SSL) Optimization and ... + Modules
  3. Seedbox Windows/Linux (uTorrent,rTorrent,libTorrent,ruTorrent) + Modules
  4. TBDev Support
  5. Gazelle Support Install
  6. TSSE Install Support
Reply With Quote
  #7  
Old 30th March 2021, 05:25
Elena's Avatar
Elena Elena is offline
Senior Member
 
Join Date: Sep 2010
Posts: 71
Default
Quote:
Originally Posted by DND View Post
your well written and fast code is still using mysql instead of mysqli or pdo .. enough said
but who likes it, likes it and will use it..despite the serious downfall
and who talked about the php7 version? There is not a word about it. Or do you think you will get what is for sale right away? Translate for yourself requests in php7, you are not forbidden. In this version, the holes were closed and the code was corrected, a new design, which Yuna does not have and did not have. And yes, many sites are still in Cyrillic, everything is done in utf8 and works faster, plus support for all languages, including Asian.

I'll give you an example of how Yuna's script works. Bluebird and teamhd work on older versions, with mysql. Bluebird is generally in Cyrillic and do not want to switch to utf8, you can compare the speed of these sites and our test.
In addition, in defense of mysql, if the script is configured correctly on nginx, then pdo is not needed.

https://teamhd.org
https://bluebird-hd.org
https://hdclub.top

Last edited by Elena; 30th March 2021 at 06:13.
Reply With Quote
  #8  
Old 31st March 2021, 01:03
darkalchemy's Avatar
darkalchemy darkalchemy is offline
Super Moderator
 
Join Date: Dec 2017
United States
Posts: 96
Default
@Elena

It's your code and you can write it any way you like. I am not posting to criticize your choice. I would just like to provide a little information. You can take it or leave it.

Minification and compression are great for artifacts(css, js, html) that the browser downloads. The browser does not download php code. The server has to open the file, read it and compile into opcode.

Since you are not compressing the file, only removing whitespace, there is no performance loss to decompress it.

When php reads a file, all comments and white space are entirely ignored by the interpreter, so there is no benefit whatsoever to removing all of the whitespace. The only thing you are adding to it by doing so is making it nearly impossible for anyone else to read your code.

I have forked your repo, added php-cs-fixer and it fails on 12 files. If you would like, I can edit your code so that it is more easily readable and update for php 7.3 which if you're doing all this for speed, is the greatest speed improvement you can do. I may do this anyway and post it to my fork.

Here is a link to a phoronix benchmark showing in all cases a 200%-500% increase in performance and reduction in processing time.

This is just my 2 cents and you don't have to agree or even listen, but I appreciate you taking the time to read it.
__________________
I do custom coding, source installs, mods, server setup and/or config, etc. Feel free to pitch me your needs and your offer.
Reply With Quote
  #9  
Old 31st March 2021, 20:03
Elena's Avatar
Elena Elena is offline
Senior Member
 
Join Date: Sep 2010
Posts: 71
Default
Quote:
Originally Posted by darkalchemy View Post
@Elena
Here is a link to a phoronix benchmark showing in all cases a 200%-500% increase in performance and reduction in processing time...
I repeat:
server: FastCGI (Nginx + PHP-FPM) PHP 5.4.16 is equivalent in speed to PHP7 in the same bundle. Do the tests themselves.
Now our test site is working on such a link, you can check the speed yourself.
Reply With Quote
  #10  
Old 31st March 2021, 23:45
rio's Avatar
rio rio is offline
Senior Member
 
Join Date: May 2019
P2P
Posts: 53
Default
I don't think anything we say is going to get through to you.
__________________
Live Free... Share Free...
Reply With Quote
Reply

Thread Tools

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump



All times are GMT +2. The time now is 01:18. vBulletin skin by ForumMonkeys. Powered by vBulletin® Version 3.8.11 Beta 3
Copyright ©2000 - 2021, vBulletin Solutions Inc.