Bravo List

Bravo List (http://www.bvlist.com/index.php)
-   Mods & Themes (http://www.bvlist.com/forumdisplay.php?f=97)
-   -   github new version (http://www.bvlist.com/showthread.php?t=12347)

Elena 28th March 2021 19:23

github new version
 
https://github.com/lolyworlds/LoLi-v3.0

rio 29th March 2021 17:32

You really need to use a code formatting tool just looking at that gave me cancer.

Elena 29th March 2021 19:49

Quote:

Originally Posted by rio (Post 55378)
You really need to use a code formatting tool just looking at the gave me cancer.

Everything is fine there, if you want with a bunch of gaps and emptiness - these are YOUR problems, you can make them for yourself. Everything is fine there - less file weight, faster opening. If there are many spaces, the reading speed slows down. Tests were made and it is not in vain that there are services that compress codes and compact them, removing emptiness and unnecessary garbage. :coffee:

rio 29th March 2021 20:44

Minifying php code has no significant performance improvements it's negligible at best.
https://stackoverflow.com/questions/...ng-php/4079952

Elena 29th March 2021 22:02

Quote:

Originally Posted by rio (Post 55380)
Minifying php code has no significant performance improvements it's negligible at best.
https://stackoverflow.com/questions/...ng-php/4079952

I repeat once again - these are your problems. You can leave at least 100 points of emptiness. The code is well written and works fast. And you have nothing to do there, you cannot improve, because you do not know the whole picture of the work. :coffee:

DND 29th March 2021 22:36

your well written and fast code is still using mysql instead of mysqli or pdo .. enough said
but who likes it, likes it and will use it..despite the serious downfall

Elena 30th March 2021 05:25

Quote:

Originally Posted by DND (Post 55382)
your well written and fast code is still using mysql instead of mysqli or pdo .. enough said
but who likes it, likes it and will use it..despite the serious downfall

and who talked about the php7 version? There is not a word about it. Or do you think you will get what is for sale right away? Translate for yourself requests in php7, you are not forbidden. In this version, the holes were closed and the code was corrected, a new design, which Yuna does not have and did not have. And yes, many sites are still in Cyrillic, everything is done in utf8 and works faster, plus support for all languages, including Asian. :coffee:

I'll give you an example of how Yuna's script works. Bluebird and teamhd work on older versions, with mysql. Bluebird is generally in Cyrillic and do not want to switch to utf8, you can compare the speed of these sites and our test.
In addition, in defense of mysql, if the script is configured correctly on nginx, then pdo is not needed.

https://teamhd.org
https://bluebird-hd.org
https://hdclub.top

darkalchemy 31st March 2021 01:03

@Elena

It's your code and you can write it any way you like. I am not posting to criticize your choice. I would just like to provide a little information. You can take it or leave it.

Minification and compression are great for artifacts(css, js, html) that the browser downloads. The browser does not download php code. The server has to open the file, read it and compile into opcode.

Since you are not compressing the file, only removing whitespace, there is no performance loss to decompress it.

When php reads a file, all comments and white space are entirely ignored by the interpreter, so there is no benefit whatsoever to removing all of the whitespace. The only thing you are adding to it by doing so is making it nearly impossible for anyone else to read your code.

I have forked your repo, added php-cs-fixer and it fails on 12 files. If you would like, I can edit your code so that it is more easily readable and update for php 7.3 which if you're doing all this for speed, is the greatest speed improvement you can do. I may do this anyway and post it to my fork.

Here is a link to a phoronix benchmark showing in all cases a 200%-500% increase in performance and reduction in processing time.

This is just my 2 cents and you don't have to agree or even listen, but I appreciate you taking the time to read it.

Elena 31st March 2021 20:03

Quote:

Originally Posted by darkalchemy (Post 55385)
@Elena
Here is a link to a phoronix benchmark showing in all cases a 200%-500% increase in performance and reduction in processing time...

I repeat:
server: FastCGI (Nginx + PHP-FPM) PHP 5.4.16 is equivalent in speed to PHP7 in the same bundle. Do the tests themselves.
Now our test site is working on such a link, you can check the speed yourself. :coffee:

rio 31st March 2021 23:45

I don't think anything we say is going to get through to you.


All times are GMT +2. The time now is 01:43.

Powered by vBulletin® Version 3.8.11 Beta 3
Copyright ©2000 - 2021, vBulletin Solutions Inc.